Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1792 Autoswitch to Move tool after selecting #1793

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shieldgenerator7
Copy link

The feature is implemented, and a checkbox option has been added to the Select tool to toggle this feature on and off. The default value is true.

I'd like this to be merged into the official program, and if not, I'd like feedback on how I can improve my code so it more closely follows the rules of this repository.

@MrStevns MrStevns self-assigned this Oct 16, 2023
@MrStevns
Copy link
Member

MrStevns commented Oct 17, 2023

Hi shieldgenerator7

First, thanks for contributing to Pencil2D.

Before reviewing the PR, I'd like to hear about why you think this is necessary and what you solve by implementing a checkbox to switch tool.

For reference:
In the current version you can move a selection by holding down 'alt', which will temporarily activate another tool, in this case the move tool.

My 2 cents:
An improvement to our current feature could be to allow operating between the two tools while some state is active (aside from the current 'alt' shortcut). In some applications this state is known as a "transformation". While in this state, you can drag, rotate and scale the object, until it has been applied, afterwards, usually by pressing enter, the tool will go back to being a normal selection.

Implementation wise this could be done via a button, something like a "Transform" button in the toolbox widget and maybe a shortcut as an alternative way to trigger the behavior. At that point though it would also make sense to create a new widget for handing the tool properties of the selection tool, rather than adding more properties to the general toolbox widget.

The overall task is more complicated as you now need to communicate back and forth between the tools but I do think that it makes more sense than a checkbox to decide to stay on the select tool or switch automatically to the move tool.

What do you think?

@J5lx J5lx added Enhancement UX Related to the way users interact with the program Select Tool Move Tool labels Oct 17, 2023
@J5lx
Copy link
Member

J5lx commented Feb 25, 2024

@shieldgenerator7 Hi, have you had a chance to look at MrStevns’s feedback yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Move Tool Select Tool UX Related to the way users interact with the program
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

After making a selection with the Select tool, auto-switch to Move tool
3 participants